Fix readyz endpoint not returning correct status when using database dynamic registration #11160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
database-access
r0mant
approved these changes
Mar 22, 2022
smallinsky
approved these changes
Mar 22, 2022
probakowski
approved these changes
Mar 24, 2022
jakule
approved these changes
Mar 25, 2022
gabrielcorado
added a commit
that referenced
this pull request
Apr 18, 2022
gabrielcorado
added a commit
that referenced
this pull request
Apr 18, 2022
gabrielcorado
added a commit
that referenced
this pull request
Apr 19, 2022
gabrielcorado
added a commit
that referenced
this pull request
Apr 19, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10077.
Change the database service start to always send a heartbeat initial when no static databases are configured. This doesn't change the current behavior where the agent doesn't wait for the dynamic databases to be discovered. It was tested with the "Reproduction steps" described in the issue.
Note: The application server also has this issue. The idea is to do the same fix after it is approved.